Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README Docs Request] A remark on setup-ros vs Docker already setup #836

Open
SteveMacenski opened this issue Nov 11, 2023 · 2 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@SteveMacenski
Copy link

After chatting with @emersonknapp about why some used configurations don't have the

      - uses: ros-tooling/setup-ros@v0.7
        with:
          required-ros-distributions: humble

stage, he mentioned that it's not necessary if using the rostooling based docker images with setup-ros done already which speeds up CI. I'd suggest adding a clear remark about that in the readme since that is a pretty ideal setup to use by default (unless users know better) so that their CI jobs are much, much faster without having to setup all of ROS.

@SteveMacenski SteveMacenski added the enhancement New feature or request label Nov 11, 2023
@christophebedard christophebedard added the documentation Improvements or additions to documentation label Nov 13, 2023
@elad-eyal
Copy link

hopefully a full example with the name of a docker image which can be used for that

@elad-eyal
Copy link

I tried the simplest example from the README on GitHub actions. After 6h of installing ROS it canceled my job; I guess if I had a container ready it would be faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants