Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split build and test steps #808

Open
audrow opened this issue Mar 29, 2023 · 0 comments
Open

Split build and test steps #808

audrow opened this issue Mar 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@audrow
Copy link

audrow commented Mar 29, 2023

Description

Currently it's only possible to build and test in the same action step. It'd be nice to have a build step and then a test step, so that it's easier to see at a glance if building failed or if testing failed. This is especially useful for a project that has common flaky tests, because a build failure is a problem but a test failure may not be as concerning.

Completion Criteria

Separate steps for building and testing a repo.

Implementation Notes / Suggestions

This logic would have to be split up between two functions.

let colconBuildCmd = [
`colcon`,
`build`,
`--symlink-install`,
...buildPackageSelection,
...colconExtraArgs,
...extraCmakeArgs,
`--event-handlers=console_cohesion+`,
];
if (useMergeInstall) {
colconBuildCmd = [...colconBuildCmd, `--merge-install`];
}
await execShellCommand(
[...colconCommandPrefix, ...colconBuildCmd],
options,
false
);
if (!skipTests) {
await runTests(
colconCommandPrefix,
options,
testPackageSelection,
colconExtraArgs,
coverageIgnorePattern
);
} else {
core.info("Skipping tests");
}

@audrow audrow added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant