Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing arbitrary arguments to colcon build and colcon test #177

Open
rotu opened this issue Apr 24, 2020 · 1 comment
Open

Allow passing arbitrary arguments to colcon build and colcon test #177

rotu opened this issue Apr 24, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rotu
Copy link
Contributor

rotu commented Apr 24, 2020 •
edited by emersonknapp

Description

This enhancement will solve a whole class of usability issues by letting users completely customize the build behavior.

Original request:

There's no way I can see to suppress other RMW implementations when building from ros2.repos. In general it may be a good option to be able to ignore packages by name.

Related Issues

Originally discovered in ros2/rmw_dds_common#16 (comment)

Completion Criteria

  • User can pass arbitrary colcon arguments
  • User can filter out unwanted packages

Implementation Notes / Suggestions

This CI action does not allow injecting additional colcon package selection arguments, which would make the functionality trivial.
@rotu rotu added the enhancement New feature or request label Apr 24, 2020
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 25, 2020
@rotu
Exclude other RMW from Github CI build
051deeb 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
@rotu rotu mentioned this issue Apr 25, 2020
Merged
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 25, 2020
@rotu
Exclude other RMW from Github CI build
6c93ba3 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 28, 2020
@rotu
Exclude other RMW from Github CI build
705302c 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 28, 2020
@rotu
Exclude other RMW from Github CI build
cd7e2f3 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 28, 2020
@rotu
Exclude other RMW from Github CI build
3dc89b8 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to ros2/rmw_cyclonedds that referenced this issue Apr 29, 2020
@rotu
Exclude other RMW from Github CI build (#168)
3397c95 
Since #145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes #164
@emersonknapp
Copy link
Contributor

This enhancement should be treated as "pass arbitrary arguments to colcon build"

Implementation note: maybe allow for passing colcon arguments list of strings for build/test each.

@emersonknapp emersonknapp changed the title Suppress RMW implementations or packages Allow passing arbitrary arguments to colcon build and colcon test Jul 31, 2020
@emersonknapp emersonknapp added help wanted Extra attention is needed enhancement New feature or request good first issue Good for newcomers and removed enhancement New feature or request labels Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rotu @emersonknapp