Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky spin test #4349

Open
SteveMacenski opened this issue May 16, 2024 · 0 comments
Open

Fix flaky spin test #4349

SteveMacenski opened this issue May 16, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@SteveMacenski
Copy link
Member

SteveMacenski commented May 16, 2024 •
edited

Test removed so that CI is green for contributors. Rewriting this test completely is probably required, this is over complicated, fragile, and tries to fake out / bypass parts of things I don't really understand why. We should just populate a costmap, call the server, check results and call it a day.

Removed in: #4348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SteveMacenski