New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary uncompatible changes in FilterBuilder class #392

Open

rulle-io opened this issue Apr 4, 2022 · 0 comments

rulle-io commented Apr 4, 2022 •

edited

We have a code piece like (new FilterBuilder().includePackage("XXX")).

It suddenly started to fail at runtime (after upgrade org.reflections:reflections:jar:0.9.12 => 0.10.2)

Caused by: java.lang.NoSuchMethodError:
'org.reflections.util.FilterBuilder org.reflections.util.FilterBuilder.includePackage(java.lang.String[])'

It turned out that public interface in FilterBuilder was changed here:

-public FilterBuilder includePackage(final String... prefixes)
+public FilterBuilder includePackage(String value)

-- Old one

reflections/src/main/java/org/reflections/util/FilterBuilder.java

Line 42 in 7741e8f

public FilterBuilder includePackage(final String... prefixes) {

-- New one

reflections/src/main/java/org/reflections/util/FilterBuilder.java

Line 36 in 1f05c17

public FilterBuilder includePackage(String value) {

This change is problematic in so many different ways: :)

You usually never just delete a public method in a public library without a proper deprecation cycle.
Changing parameter from java.lang.String[] to String will make compilation work for some use-cases, and not for others.
It breaks the binary compatibility.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment