Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable automatic module name #308

Merged
merged 2 commits into from Oct 7, 2021
Merged

Enable automatic module name #308

merged 2 commits into from Oct 7, 2021

Conversation

TrackerSB
Copy link

Introduce compatibility with most recent JDKs

@TrackerSB
Enable automatic module name
87ffcf4 
Introduce compatibility with most recent JDKs
@TrackerSB
Correct module name
797df6b
@rjbaucells
Copy link

This simple addition to the jar manifest removes compiling warnings under JDK9+ when having this library as a dependency of a JDK Module aware library:

[WARNING] **********************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [reflections-0.9.12.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] **********************************************************************************************************************************************

@astubbs
Copy link

astubbs commented Sep 3, 2021

duplicates #305

@astubbs astubbs mentioned this pull request Sep 3, 2021
Closed
@ronmamo ronmamo changed the base branch from master to ref-0.10.1 October 7, 2021 04:32
@ronmamo ronmamo merged commit 58b9cc7 into ronmamo:ref-0.10.1 Oct 7, 2021
ronmamo added a commit that referenced this pull request Oct 7, 2021
@ronmamo
ref-0.10.1 - fix exception, docs, ci matrix, dependabot
b7e8f9a 
* 0.10.1 - fix exception in JavassistHelper.getParametersAnnotations, docs

* ci: Setup GitHub actions for basic PR CI (#333)

* Make the path format to be platform-compatible (#299)

* enable Dependabot v2 (#319)

* Enable automatic module name (#308)
@ronmamo
Copy link
Owner

ronmamo commented Oct 7, 2021

thanks @TrackerSB , apologize for the (1 year) delay :)

@gharris1727 gharris1727 mentioned this pull request Jul 17, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidShahbazyan DavidShahbazyan DavidShahbazyan approved these changes

Assignees
No one assigned
Labels
marked for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TrackerSB @rjbaucells @astubbs @ronmamo @DavidShahbazyan