Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with module dependency #5

Closed
bvwells opened this issue Dec 14, 2021 · 1 comment
Closed

Issue with module dependency #5

bvwells opened this issue Dec 14, 2021 · 1 comment

Comments

@bvwells
Copy link

bvwells commented Dec 14, 2021

This module pulls in a dependency on github.com/prometheus/common@v0.15.0 in the file

"github.com/prometheus/common/log"

where it uses the log package.

This version of the dependency is quite out of date and the log package in github.com/prometheus/common is actually now deprecated (see prometheus/common#306, https://github.com/prometheus/common/releases/tag/v0.27.0)

This dependency causes some issues when using this module in a module which uses a more recent version of github.com/prometheus/common as go can't detect the correct module version of github.com/prometheus/common to use (due to the log package removal being a breaking change). Consumers end up with errors of the form:

> go mod tidy
....
        github.com/romnn/testcontainers imports
        github.com/prometheus/common/log: module github.com/prometheus/common@latest found (v0.32.1), but does not contain package github.com/prometheus/common/log

I looks like this dependency could be completely removed as it is only used to log an error. I wonder if the standard go log package would suffice here...

Happy to raise a PR if you think that this is a suitable solution.

@romnn
Copy link
Owner

romnn commented Oct 20, 2022

Dear @bvwells, thanks for your contribution!

Excuse the late follow up, I have not been actively working on this. I just updated the dependencies and refactored the code, which should resolve this issue (only standard go logging is used).

Best, Roman

@romnn romnn closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants