Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying ContainerOptions configs for Kafka #11

Open
GRbit opened this issue Nov 7, 2022 · 0 comments
Open

Modifying ContainerOptions configs for Kafka #11

GRbit opened this issue Nov 7, 2022 · 0 comments

Comments

@GRbit
Copy link

GRbit commented Nov 7, 2022

Thank you very much for your library, it's very convenient and I love it!

I used it in bitbucket pipelines and successfully run Redis passing "SkipReaper" via ContainerOptions (bitbucket has strict limitations for containers in the pipeline). But I wasn't able to do the same for Kafka, because the options struct is merged only with a Kafka container. So, I've ended up copying some code from your library to be able to set the needed options.

I kindly ask you to add a way to pass options for network and zookeeper containers. Maybe by merging options to every container, maybe, but adding several options variables, is up to you to choose.

Thank you again for creating such an amazing library, I was very glad to find it.

P.S.: In case you are too busy to add it, but you are ok with me creating a PR, write here a few words about how you want it to be. Maybe I'll find some time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant