Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish universal-darwin #13

Closed
clason opened this issue Apr 6, 2021 · 6 comments · Fixed by #14
Closed

Publish universal-darwin #13

clason opened this issue Apr 6, 2021 · 6 comments · Fixed by #14

Comments

@clason
Copy link

clason commented Apr 6, 2021

This might be invalid (can't try yet), but there are reports that fzy-lua-native doesn't work (out of the box?) on Apple Silicon. It'd be great if that architecture could be included in the static builds through GHA, either as a separate library or a universal build. (Not sure which is easier.)

Maybe actions/runner#805 (comment) is enough? Or is that only addressing local runners?

If so, do you have any instructions for locally building a native M1 extension?

@romgrk
Copy link
Owner

romgrk commented Apr 7, 2021

Duplicate of #9, indeed M1 is not prebuilt at the moment. @mherna seems to have built the project without difficulty, I'd expect make to be enough.

Not sure what's an universal build? How does that work?

Otherwise if someone wants to build & provide a compiled binary I'd be ok with including it in the repo, at this point the repo should be very stable for a while so I don't expect to need to rebuild the binaries soon.

@clason
Copy link
Author

clason commented Apr 7, 2021

Ah, didn't see that issue (since it was closed without resolution).

If make is enough to build a native binary, that'd be good enough for me (maybe mention it in the README?), but I'd be happy to provide the binary for download as well. (I don't have an M1 yet.)

(A universal binary is a binary that combines both x86 and ARM code, so the same binary runs -- natively -- on both architectures; see https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary)

@romgrk
Copy link
Owner

romgrk commented Apr 7, 2021

Interesting feature, but I'd rather just compile separate binaries for separate architectures, because that's what we are already doing for all other OS:es.

And for the native binary sure, if someone (that I can trust - public profile, contributions to known repos) wants to make and open a PR with the missing binary I'll merge it. Signed commit would be nice.

@clason
Copy link
Author

clason commented Apr 7, 2021

Interesting feature, but I'd rather just compile separate binaries for separate architectures, because that's what we are already doing for all other OS:es.

Yeah, makes sense. I thought universal would be easier (especially if it allows cross-compilation without native runners), but if that's not the case, there's no reason for it.

And for the native binary sure, if someone (that I can trust - public profile, contributions to known repos) wants to make and open a PR with the missing binary I'll merge it. Signed commit would be nice.

Would @smolck count? ;) I'll ping you again when I have my machine set up.

@smolck
Copy link
Contributor

smolck commented Apr 7, 2021

And for the native binary sure, if someone (that I can trust - public profile, contributions to known repos) wants to make and open a PR with the missing binary I'll merge it. Signed commit would be nice.

Would @smolck count? ;) I'll ping you again when I have my machine set up.

If so, I'm happy to do this (including the signed commit, just got that set up). Just give me the go-ahead @romgrk and I'll open a PR (or don't and I won't ;)).

@romgrk
Copy link
Owner

romgrk commented Apr 7, 2021

Lol yes sure I trust @smolck ^^ Go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants