Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maxParallelFileOps to limit parallel writes #4570

Merged
merged 1 commit into from Jul 15, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Previously, we added --maxParallelFileReads to limit how many parallel files to read on systems with restricted file handles. This PR replaces this (actually soft-deprecates the previous option) with a --maxParallelFileOps option which will also limit writing chunks to disk, as you can face a similar scenario e.g. when preserving modules.

@github-actions
Copy link

github-actions bot commented Jul 14, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#max-parallel-file-ops

or load it into the REPL:
https://rollupjs.org/repl/?pr=4570

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #4570 (b2a7d58) into master (0eb0427) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4570   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         209      209           
  Lines        7346     7350    +4     
  Branches     2098     2100    +2     
=======================================
+ Hits         7263     7267    +4     
  Misses         27       27           
  Partials       56       56           
Impacted Files Coverage Δ
src/utils/options/mergeOptions.ts 100.00% <ø> (ø)
src/Graph.ts 100.00% <100.00%> (ø)
src/ModuleLoader.ts 100.00% <100.00%> (ø)
src/rollup/rollup.ts 100.00% <100.00%> (ø)
src/utils/Queue.ts 100.00% <100.00%> (ø)
src/utils/options/normalizeInputOptions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb0427...b2a7d58. Read the comment docs.

@lukastaegert lukastaegert merged commit b7e451c into master Jul 15, 2022
@lukastaegert lukastaegert deleted the max-parallel-file-ops branch July 15, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant