Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use includes where appropriate #4412

Merged
merged 4 commits into from Feb 21, 2022

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #4412 (e97c2b7) into master (213e721) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4412      +/-   ##
==========================================
+ Coverage   98.72%   98.75%   +0.02%     
==========================================
  Files         204      204              
  Lines        7322     7322              
  Branches     2080     2079       -1     
==========================================
+ Hits         7229     7231       +2     
+ Misses         34       33       -1     
+ Partials       59       58       -1     
Impacted Files Coverage Δ
browser/path.ts 78.57% <100.00%> (+1.64%) ⬆️
cli/run/index.ts 100.00% <100.00%> (ø)
src/Chunk.ts 100.00% <100.00%> (ø)
src/finalisers/iife.ts 100.00% <100.00%> (ø)
src/utils/getExportMode.ts 100.00% <100.00%> (ø)
src/utils/options/mergeOptions.ts 100.00% <100.00%> (ø)
src/utils/path.ts 100.00% <100.00%> (+33.33%) ⬆️
src/watch/watch.ts 99.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213e721...e97c2b7. Read the comment docs.

@lukastaegert lukastaegert merged commit 70d0025 into rollup:master Feb 21, 2022
@dnalborczyk dnalborczyk deleted the index-includes branch February 22, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants