Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use map for namespace reexports by name #4411

Merged
merged 9 commits into from Feb 22, 2022

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #4411 (0611d17) into master (2cca505) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4411   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         204      204           
  Lines        7322     7322           
  Branches     2079     2079           
=======================================
  Hits         7231     7231           
  Misses         33       33           
  Partials       58       58           
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cca505...0611d17. Read the comment docs.

@dnalborczyk
Copy link
Contributor Author

@lukastaegert is this: f7434c3 possibly a left-over from some previous iteration of the code? should this remain in place? I couldn't find any purpose in the synchronous execution flow. if there is one, it's not covered by a test.

src/Module.ts Outdated
@@ -463,8 +464,6 @@ export default class Module {
if (this.transitiveReexports) {
return this.transitiveReexports;
}
// to avoid infinite recursion when using circular `export * from X`
this.transitiveReexports = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would very much expect this one to be needed, maybe a test is missing. After all, there is a recursion in line 475 which needs to be broken if there is a cycle. Will need to look into this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a failing test for this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you! I'll revert.

src/Module.ts Outdated
@@ -463,8 +464,6 @@ export default class Module {
if (this.transitiveReexports) {
return this.transitiveReexports;
}
// to avoid infinite recursion when using circular `export * from X`
this.transitiveReexports = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a failing test for this one

@lukastaegert lukastaegert enabled auto-merge (squash) February 22, 2022 05:59
@lukastaegert lukastaegert merged commit 3106ec9 into rollup:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants