New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use map for namespace reexports by name #4411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4411 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 204 204
Lines 7322 7322
Branches 2079 2079
=======================================
Hits 7231 7231
Misses 33 33
Partials 58 58
Continue to review full report at Codecov.
|
@lukastaegert is this: f7434c3 possibly a left-over from some previous iteration of the code? should this remain in place? I couldn't find any purpose in the synchronous execution flow. if there is one, it's not covered by a test. |
src/Module.ts
Outdated
@@ -463,8 +464,6 @@ export default class Module { | |||
if (this.transitiveReexports) { | |||
return this.transitiveReexports; | |||
} | |||
// to avoid infinite recursion when using circular `export * from X` | |||
this.transitiveReexports = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would very much expect this one to be needed, maybe a test is missing. After all, there is a recursion in line 475 which needs to be broken if there is a cycle. Will need to look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a failing test for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! thank you! I'll revert.
src/Module.ts
Outdated
@@ -463,8 +464,6 @@ export default class Module { | |||
if (this.transitiveReexports) { | |||
return this.transitiveReexports; | |||
} | |||
// to avoid infinite recursion when using circular `export * from X` | |||
this.transitiveReexports = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a failing test for this one
This reverts commit f7434c3.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description