Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ids for unfinished moduleParsed and shouldTransformCachedModule hooks #4409

Merged
merged 3 commits into from Feb 18, 2022

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Feb 17, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4408

Description

This adds module ids to the output when there are unfinished hook actions for the moduleParsed and shouldTransformCachedModule hooks.

Also, it resolves a situation where an error message was suppressed due to unfinished hook actions.

@github-actions
Copy link

github-actions bot commented Feb 17, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#more-unfinished-hooks-info

or load it into the REPL:
https://rollupjs.org/repl/?pr=4409

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #4409 (f8b2ca7) into master (d4471b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4409   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files         204      204           
  Lines        7319     7323    +4     
  Branches     2081     2081           
=======================================
+ Hits         7226     7230    +4     
  Misses         34       34           
  Partials       59       59           
Impacted Files Coverage Δ
src/utils/hookActions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4471b4...f8b2ca7. Read the comment docs.

@lukastaegert lukastaegert merged commit fda4427 into master Feb 18, 2022
@lukastaegert lukastaegert deleted the more-unfinished-hooks-info branch February 18, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error thrown being supressed in favour of "unfinished hook action(s)" message
1 participant