Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how resolveId is cached #4407

Merged
merged 1 commit into from Feb 17, 2022
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

When working on caching the commonjs plugin, I found that it is not documented that caching will not only skip the load hook but also the resolveId hook of dependencies (which does indeed save a lot).

@github-actions
Copy link

github-actions bot commented Feb 16, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#document-resolve-id-caching

or load it into the REPL:
https://rollupjs.org/repl/?pr=4407

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #4407 (6c34232) into master (5bd96df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4407   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         204      204           
  Lines        7319     7319           
  Branches     2081     2081           
=======================================
  Hits         7226     7226           
  Misses         34       34           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd96df...6c34232. Read the comment docs.

@lukastaegert lukastaegert merged commit d4471b4 into master Feb 17, 2022
@lukastaegert lukastaegert deleted the document-resolve-id-caching branch February 17, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant