From 135400f17668d02e25cddc42e6ebfa89c2f157e0 Mon Sep 17 00:00:00 2001 From: Daniel Nalborczyk Date: Sun, 13 Feb 2022 15:10:05 -0500 Subject: [PATCH 1/2] fix: remove unnecessary property descriptor spread --- src/ExternalModule.ts | 1 - src/Module.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/src/ExternalModule.ts b/src/ExternalModule.ts index b1862720bb8..a10b06633fc 100644 --- a/src/ExternalModule.ts +++ b/src/ExternalModule.ts @@ -73,7 +73,6 @@ export default class ExternalModule { }); // Hide the deprecated key so that it only warns when accessed explicitly Object.defineProperty(this.info, 'hasModuleSideEffects', { - ...Object.getOwnPropertyDescriptor(this.info, 'hasModuleSideEffects'), enumerable: false }); } diff --git a/src/Module.ts b/src/Module.ts index 056217768e5..dfbb75860ac 100644 --- a/src/Module.ts +++ b/src/Module.ts @@ -335,7 +335,6 @@ export default class Module { }; // Hide the deprecated key so that it only warns when accessed explicitly Object.defineProperty(this.info, 'hasModuleSideEffects', { - ...Object.getOwnPropertyDescriptor(this.info, 'hasModuleSideEffects'), enumerable: false }); } From 95bfc1383c2560d1a0bb5e242ad8f9b8c63ab1ee Mon Sep 17 00:00:00 2001 From: Lukas Taegert-Atkinson Date: Mon, 14 Feb 2022 06:43:10 +0100 Subject: [PATCH 2/2] Simplify import --- src/Module.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Module.ts b/src/Module.ts index dfbb75860ac..2f712b5d3fa 100644 --- a/src/Module.ts +++ b/src/Module.ts @@ -5,6 +5,7 @@ import MagicString from 'magic-string'; import ExternalModule from './ExternalModule'; import type Graph from './Graph'; import { createHasEffectsContext, createInclusionContext } from './ast/ExecutionContext'; +import { nodeConstructors } from './ast/nodes'; import ExportAllDeclaration from './ast/nodes/ExportAllDeclaration'; import ExportDefaultDeclaration from './ast/nodes/ExportDefaultDeclaration'; import type ExportNamedDeclaration from './ast/nodes/ExportNamedDeclaration'; @@ -17,7 +18,6 @@ import * as NodeType from './ast/nodes/NodeType'; import Program from './ast/nodes/Program'; import TemplateLiteral from './ast/nodes/TemplateLiteral'; import VariableDeclaration from './ast/nodes/VariableDeclaration'; -import { nodeConstructors } from './ast/nodes/index'; import type { ExpressionNode, NodeBase } from './ast/nodes/shared/Node'; import ModuleScope from './ast/scopes/ModuleScope'; import { type PathTracker, UNKNOWN_PATH } from './ast/utils/PathTracker';