Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test stability by getting independent of module id ordering in more places #4401

Merged
merged 3 commits into from Feb 14, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

There were still some cases where module ids in tests were not properly ordered. This fixes this by using objects instead of arrays in some places, which also improves readability.

@github-actions
Copy link

github-actions bot commented Feb 13, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#order-test-module-ids

or load it into the REPL:
https://rollupjs.org/repl/?pr=4401

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #4401 (de249ef) into master (f715e3c) will not change coverage.
The diff coverage is n/a.

❗ Current head de249ef differs from pull request most recent head a0ee040. Consider uploading reports for the commit a0ee040 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4401   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         204      204           
  Lines        7325     7325           
  Branches     2081     2081           
=======================================
  Hits         7232     7232           
  Misses         34       34           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d76887...a0ee040. Read the comment docs.

@dnalborczyk
Copy link
Contributor

dnalborczyk commented Feb 13, 2022

@dnalborczyk
Copy link
Contributor

@lukastaegert are there (a lot?) of tests left needing to be fixed? anything I can help with?

@lukastaegert
Copy link
Member Author

this might be another on

These are the reason I did this 😉

@lukastaegert are there (a lot?) of tests left needing to be fixed?

I hope not, but no way to be sure

@lukastaegert lukastaegert merged commit 16c3b24 into master Feb 14, 2022
@lukastaegert lukastaegert deleted the order-test-module-ids branch February 14, 2022 05:30
@dnalborczyk
Copy link
Contributor

this might be another on

These are the reason I did this 😉

@lukastaegert are there (a lot?) of tests left needing to be fixed?

I hope not, but no way to be sure

ah, sweet!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants