Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove confusing code in javascript-api.md #4399

Merged
merged 1 commit into from Feb 13, 2022

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for spotting

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #4399 (797c5fa) into master (60706c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4399   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         204      204           
  Lines        7325     7325           
  Branches     2081     2081           
=======================================
  Hits         7232     7232           
  Misses         34       34           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60706c3...797c5fa. Read the comment docs.

@lukastaegert lukastaegert merged commit f715e3c into rollup:master Feb 13, 2022
@TrickyPi TrickyPi deleted the docs-fix branch February 13, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants