Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add @types/estree explicitly, fix dynamic type imports #4390

Merged
merged 6 commits into from Feb 9, 2022

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Feb 7, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

  • @types/estree was available only implicitly thru other dependencies.
  • also replaced the dynamic type imports in declarations. (I believe that's meant for non-module imports, where there's no other way to import types otherwise.)
  • simplified NodeWithFieldDefinition union type definition
  • bumped some deps.

before:
image

after:
image

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4390 (69ea809) into master (903b464) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4390   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         204      204           
  Lines        7320     7320           
  Branches     2080     2080           
=======================================
  Hits         7227     7227           
  Misses         34       34           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903b464...69ea809. Read the comment docs.

@dnalborczyk dnalborczyk changed the title chore: add @types/estree explicitly chore: add @types/estree explicitly, fix dynamic type imports Feb 7, 2022
@dnalborczyk
Copy link
Contributor Author

https://github.com/rollup/rollup/runs/5100138440?check_suite_focus=true seems is a left-over failing test case from fs.promises/chunks.

@dnalborczyk dnalborczyk changed the title chore: add @types/estree explicitly, fix dynamic type imports refactor: add @types/estree explicitly, fix dynamic type imports Feb 8, 2022
@lukastaegert lukastaegert enabled auto-merge (squash) February 9, 2022 06:02
@lukastaegert lukastaegert merged commit 5f4d04f into rollup:master Feb 9, 2022
@dnalborczyk dnalborczyk deleted the add-types-estree branch February 10, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants