Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fs.promises in generate license file, rollup config, Part 5 #4389

Merged
merged 4 commits into from Feb 7, 2022

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #4389 (bcef8d2) into master (33a4278) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4389   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         204      204           
  Lines        7315     7320    +5     
  Branches     2082     2080    -2     
=======================================
+ Hits         7222     7227    +5     
  Misses         34       34           
  Partials       59       59           
Impacted Files Coverage Δ
cli/run/batchWarnings.ts 99.20% <100.00%> (+<0.01%) ⬆️
src/Chunk.ts 100.00% <100.00%> (ø)
src/Module.ts 100.00% <100.00%> (ø)
src/ModuleLoader.ts 100.00% <100.00%> (ø)
src/utils/resolveId.ts 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ee52c...bcef8d2. Read the comment docs.

@dnalborczyk dnalborczyk marked this pull request as ready for review February 7, 2022 03:49
@lukastaegert lukastaegert enabled auto-merge (squash) February 7, 2022 05:03
@lukastaegert lukastaegert merged commit aad5510 into rollup:master Feb 7, 2022
@dnalborczyk dnalborczyk deleted the fs-promises-part-5 branch February 12, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants