New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use fs.promises in resolve id, Part 4 #4386
Conversation
this causes tests to build in a non-deterministic order, similarly what is reported here: #4337 I have to digg thru the code to get more information. we probably need some deterministic processing queue (FIFO?) in order of the imported files during parsing. there is also a specific test case which produces different results each time you run rollup. all results are runnable and perfectly fine, but contain different generated variable names. I think it's important to have deterministic builds (when input hasn't changed), it would also make testing way harder. let me try to find it .... other than that, most failing tests have a different order of module ids. |
for example his one:
run again
|
Codecov Report
@@ Coverage Diff @@
## master #4386 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 204 204
Lines 7315 7320 +5
Branches 2082 2080 -2
=======================================
+ Hits 7222 7227 +5
Misses 34 34
Partials 59 59
Continue to review full report at Codecov.
|
I pushed some fixes. For the most part, those are test fixes, i.e. sorting watchFiles or moduleIds before asserting, because I do not think those need to be necessarily deterministic. |
yeah, I agree, I was thinking the same.
that's awesome! thank you for looking into this! |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description