Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timed plugin context #4357

Merged
merged 2 commits into from Jan 21, 2022

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Jan 20, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

fixes: 7c47283#r64105152

also removes the unnecessary timedPlugin object and wraps the functions directly.

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #4357 (efc5ca6) into master (a5988dc) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4357      +/-   ##
==========================================
+ Coverage   98.51%   98.69%   +0.17%     
==========================================
  Files         205      205              
  Lines        7329     7329              
  Branches     2084     2084              
==========================================
+ Hits         7220     7233      +13     
+ Misses         51       36      -15     
- Partials       58       60       +2     
Impacted Files Coverage Δ
src/utils/timers.ts 82.14% <100.00%> (+23.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5988dc...efc5ca6. Read the comment docs.

@dnalborczyk dnalborczyk marked this pull request as ready for review January 21, 2022 01:38
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@lukastaegert lukastaegert merged commit d1079a3 into rollup:master Jan 21, 2022
@SuperOleg39
Copy link
Contributor

Thanks!

@dnalborczyk dnalborczyk deleted the fix-timed-plugin-context branch January 22, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants