Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Array.prototype.findLast,findLastIndex #4332

Merged
merged 1 commit into from Jan 4, 2022

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 30, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

not quite stage 4 yet: needs engine implementers before reaching stage 4, but I don't think much (if anything) is gonna change.

https://v8.dev/blog/v8-release-97

@dnalborczyk dnalborczyk force-pushed the array-find-last branch 2 times, most recently from 8a591b2 to 63d6df6 Compare December 30, 2021 17:48
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #4332 (2be6bd7) into master (7f55571) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4332   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         205      205           
  Lines        7314     7314           
  Branches     2084     2084           
=======================================
  Hits         7200     7200           
  Misses         55       55           
  Partials       59       59           
Impacted Files Coverage Δ
src/ast/nodes/shared/ArrayPrototype.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f55571...2be6bd7. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit 342ba2c into rollup:master Jan 4, 2022
@dnalborczyk dnalborczyk deleted the array-find-last branch January 6, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants