refactor: type fixes #4326
Merged
refactor: type fixes #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4326 +/- ##
==========================================
- Coverage 98.44% 98.44% -0.01%
==========================================
Files 206 206
Lines 7353 7350 -3
Branches 2089 2088 -1
==========================================
- Hits 7239 7236 -3
Misses 55 55
Partials 59 59
Continue to review full report at Codecov.
|
dnalborczyk
force-pushed
the
queue-cleanup-types
branch
from
1b8eee5
to
67f74e2
Compare
dnalborczyk
force-pushed
the
queue-cleanup-types
branch
from
15484d1
to
6814d5b
Compare
lukastaegert
approved these changes
Jan 4, 2022
| private indentString: string = undefined as never; | ||
| private readonly isEmpty: boolean = true; |
There was a problem hiding this comment.
To my understanding it is ok to mark something as readonly if it is only changed in the constructor. It will prevent mutations in all other methods.
lukastaegert
reviewed
Jan 4, 2022
src/utils/queue.ts
Outdated
| private workerCount = 0; | ||
|
|
||
| constructor(public maxParallel = 1) {} | ||
| constructor(private maxParallel = 1) {} |
There was a problem hiding this comment.
The fallback = 1 is no longer needed (and bad for coverage 😉)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description