Restrict parallel execution of load hook. #4200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4200 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 202 202
Lines 7254 7253 -1
Branches 2127 2126 -1
==========================================
- Hits 7136 7135 -1
Misses 58 58
Partials 60 60
Continue to review full report at Codecov.
|
|
The failed Windows test seems to be a temporary GitHub Issue to me. Not sure what to do about the -0.01% coverage drop, because all edited lines are fully covered, it's just that's it's one line less than before, bringing the average down. Can this check be ignored? Otherwise I'd have to write a test for something completely unrelated to the PR 😁 |
I know this edge case. Unfortunately, I did not find a way to fix this easily, just ignore it. I will have a look at the PR likely tomorrow. |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Follow up to #4170
I had more "EMFILE: too many open files" errors in another project and realized the reason for this that the fix in #4170 does not apply when a load hook is provided. We can assume that load hooks will often use fs.readFile as well and therefore be subject to the same problem with too many parallel file read. I think it makes sense to extend the scope of the readQueue and also channel the load hook through it.