New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align batch warning for UNUSED_EXTERNAL_IMPORT to individual warning #4194
Conversation
73c1f92
to
edbb2c8
Compare
edbb2c8
to
a2d27ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #4194 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 202 202
Lines 7243 7244 +1
Branches 2123 2123
=======================================
+ Hits 7123 7124 +1
Misses 58 58
Partials 62 62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice addition, just a small potential cleanup (that should also fix coverage).
@@ -16,7 +16,7 @@ module.exports = { | |||
assertIncludes( | |||
stderr, | |||
'(!) Unused external imports\n' + | |||
"default imported from external module 'external' but never used\n" | |||
`default imported from external module 'external' but never used in "main.js"\n` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it, maybe we could align on using double quotes "
also for the module name. This is also what most other errors use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
The original issue which was closed is #4052. This finishes addressing that issue
Description
PR #4054 improved the individual warning, but did not update the batch warning. When I build SvelteKit with Vite, which uses Rollup, I get a warning that I can't understand the origin of or how to fix
After using a locally modified copy, I was quickly able to track down the culprit: ampproject/amphtml#35435