Move long path recursion prevention to MemberExpression #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
force-pushed
the
gh-4184-deoptimization-recursion
branch
from
27487c5
to
af90dc4
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4184-deoptimization-recursionor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4189 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 202 202
Lines 7232 7245 +13
Branches 2116 2123 +7
=======================================
+ Hits 7112 7125 +13
Misses 58 58
Partials 62 62
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
gh-4184-deoptimization-recursion
branch
from
af90dc4
to
6ca5536
Compare
lukastaegert
force-pushed
the
gh-4184-deoptimization-recursion
branch
from
6ca5536
to
c00cc93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4184
Description
This resolves a regression reported when calling class methods that themselves call methods on "this". Here it was possible that Rollup was trying to deoptimize an infinite object path (basically
.prototype.prototype.prototype...). This is resolved by moving the logic to prevent these things from the LocalVariable class to the MemberExpression class as the latter is actually the one responsible for the issue.