Deoptimize return values of async functions #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#deoptimize-async-functionsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4163 +/- ##
=======================================
Coverage 98.28% 98.29%
=======================================
Files 201 201
Lines 7130 7149 +19
Branches 2089 2093 +4
=======================================
+ Hits 7008 7027 +19
Misses 58 58
Partials 64 64
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
deoptimize-async-functions
branch
from
2493164
to
654bfa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This is a follow-up to #4161 resolving #4161 (comment). The problem is that for async functions, we were not properly deoptimizing the return value, which is fixed here.