Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max stack call error is caught on locate #4160

Merged
merged 1 commit into from Jul 1, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Jun 30, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Resolves #4150

Description

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge it once CI approves as well :)

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #4160 (8e13b8c) into master (c3ad218) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4160   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         201      201           
  Lines        7125     7127    +2     
  Branches     2087     2088    +1     
=======================================
+ Hits         7003     7005    +2     
  Misses         58       58           
  Partials       64       64           
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ad218...8e13b8c. Read the comment docs.

@lukastaegert lukastaegert merged commit a632d50 into rollup:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack error during parsing results in wrong error message
2 participants