Do not track side-effect-free array methods as side effects

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
#4100 (but does not fully resolve it)

Description

This will no longer track calling array builtin methods such as filter as side-effects: REPL

Note that when the array itself is later passed to a function (like console.log), Rollup will still optimise as it cannot track if the filter methods was overwritten.

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4100-no-side-effect-array-methods

or load it into the REPL:
https://rollupjs.org/repl/?pr=4103

[codecov]

Codecov Report

Merging #4103 (9473af9) into master (9a50fbb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4103   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         201      201           
  Lines        7036     7037    +1     
  Branches     2063     2063           
=======================================
+ Hits         6897     6898    +1     
  Misses         66       66           
  Partials       73       73           

Impacted Files	Coverage Δ
src/ast/nodes/shared/MethodTypes.ts	78.57% <ø> (ø)
src/ast/nodes/shared/ArrayPrototype.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a50fbb...9473af9. Read the comment docs.