Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rollup logo in README.md #4080

Merged
merged 4 commits into from May 15, 2021
Merged

Added Rollup logo in README.md #4080

merged 4 commits into from May 15, 2021

Conversation

priyanshurav
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This PR adds the Rollup logo to README.md

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the changes to the lockfile. While we will likely update to npm 7 soon, I would like you to revert the change for now.

@priyanshurav
Copy link
Contributor Author

@lukastaegert I have now reverted the changes made to the lockfile.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install priyanshurav/rollup#added-rollup-logo-to-readme

or load it into the REPL:
https://rollupjs.org/repl/?pr=4080

@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #4080 (d2cb4bc) into master (2bee261) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4080   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         193      193           
  Lines        6818     6824    +6     
  Branches     2002     2005    +3     
=======================================
+ Hits         6647     6653    +6     
  Misses         84       84           
  Partials       87       87           
Impacted Files Coverage Δ
src/Graph.ts 100.00% <100.00%> (ø)
src/utils/pureComments.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40d206...d2cb4bc. Read the comment docs.

@lukastaegert lukastaegert merged commit b460516 into rollup:master May 15, 2021
@priyanshurav priyanshurav deleted the added-rollup-logo-to-readme branch May 15, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants