New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Rollup logo in README.md #4080
Added Rollup logo in README.md #4080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the changes to the lockfile. While we will likely update to npm 7 soon, I would like you to revert the change for now.
…anshurav/rollup into added-rollup-logo-to-readme
@lukastaegert I have now reverted the changes made to the lockfile. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install priyanshurav/rollup#added-rollup-logo-to-readme or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4080 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 193 193
Lines 6818 6824 +6
Branches 2002 2005 +3
=======================================
+ Hits 6647 6653 +6
Misses 84 84
Partials 87 87
Continue to review full report at Codecov.
|
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR adds the Rollup logo to README.md