New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanitizeFileName option #4058
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install guybedford/rollup#sanitize-file-names or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4058 +/- ##
==========================================
- Coverage 97.45% 97.43% -0.02%
==========================================
Files 192 192
Lines 6795 6794 -1
Branches 1996 1995 -1
==========================================
- Hits 6622 6620 -2
Misses 84 84
- Partials 89 90 +1
Continue to review full report at Codecov.
|
Thanks for the review, I've pushed the changes, there's just the question of the default argument left to resolve as per discussion above. |
I've added the validation changes here, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
As an alternative to #4050 this provides a
sanitizeFileNames
output option that can be set to a function or false to allow hooking or disabling the chunk name sanitization process.//cc @lukastaegert