Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov action for coverage #4046

Merged
merged 1 commit into from Apr 15, 2021
Merged

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 15, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

It seems that coverage reporting is still off in that it uses the wrong commit to identify the report. This tries to fix it by using the codecov Github action.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-coverage-reporting

or load it into the REPL:
https://rollupjs.org/repl/?pr=4046

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #4046 (2f47122) into master (ef807c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4046   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         192      192           
  Lines        6788     6788           
  Branches     1996     1996           
=======================================
  Hits         6617     6617           
  Misses         84       84           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef807c9...2f47122. Read the comment docs.

@lukastaegert lukastaegert merged commit a4a3b8a into master Apr 15, 2021
@lukastaegert lukastaegert deleted the fix-coverage-reporting branch April 15, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant