Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix vscode launch config (change tdd to bdd) #4026

Merged
merged 1 commit into from Mar 29, 2021

Conversation

jameslahm
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Tests will fail to run in vscode debugger if we use tdd in .vscode/launch.json, because describe is not defined in tdd style. Changing tdd to bdd would make tests run normal.

References

https://mochajs.org/#interfaces

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #4026 (51f22e6) into master (e1dd08a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4026   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         192      192           
  Lines        6771     6771           
  Branches     1983     1983           
=======================================
  Hits         6600     6600           
  Misses         84       84           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1dd08a...51f22e6. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a VSCode user but the change looks reasonable

@lukastaegert lukastaegert merged commit c008f3e into rollup:master Mar 29, 2021
lukastaegert pushed a commit to lukastaegert/rollup that referenced this pull request Mar 29, 2021
lukastaegert pushed a commit to lukastaegert/rollup that referenced this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants