Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle recursive this mutation detection #4025

Merged
merged 2 commits into from Mar 28, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4024

Description

The new method was missing recursion detection, which is added here. cc @marijnh

@rollup-bot
Copy link
Collaborator

rollup-bot commented Mar 28, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh4024-fix-infinite-recursion

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14774

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #4025 (af34ea7) into master (dbf369f) will increase coverage by 0.03%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
+ Coverage   97.44%   97.47%   +0.03%     
==========================================
  Files         192      192              
  Lines        6762     6771       +9     
  Branches     1981     1983       +2     
==========================================
+ Hits         6589     6600      +11     
+ Misses         85       84       -1     
+ Partials       88       87       -1     
Impacted Files Coverage Δ
src/ast/nodes/shared/MultiExpression.ts 95.00% <0.00%> (ø)
src/ast/nodes/Identifier.ts 98.14% <50.00%> (+0.03%) ⬆️
src/ast/nodes/CallExpression.ts 95.49% <100.00%> (+0.04%) ⬆️
src/ast/nodes/MemberExpression.ts 99.18% <100.00%> (ø)
src/ast/nodes/ObjectExpression.ts 94.48% <100.00%> (+0.03%) ⬆️
src/ast/nodes/shared/Node.ts 100.00% <100.00%> (ø)
src/ast/variables/LocalVariable.ts 91.00% <100.00%> (+2.70%) ⬆️
src/ast/variables/Variable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf369f...af34ea7. Read the comment docs.

@lukastaegert lukastaegert merged commit fb26847 into master Mar 28, 2021
@lukastaegert lukastaegert deleted the gh4024-fix-infinite-recursion branch March 28, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mayModifyThisWhenCalledAtPath causes RangeError: Maximum call stack size exceeded (v2.43.0 only)
2 participants