Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SIGTERM instead of SIGINT to kill test child processes #4015

Merged
merged 1 commit into from Mar 25, 2021

Conversation

marijnh
Copy link
Contributor

@marijnh marijnh commented Mar 25, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Since SIGINT fails to actually kill them on some platforms under some circumstances,
leading to a whole lot of watch tests sitting around for 40 seconds until they
time out.

See derail in the discussion for issue #3989

Since SIGINT fails to actually kill them on some platforms under some circumstances,
leading to a whole lot of watch tests sitting around for 40 seconds until they
time out.

See derail in the discussion for issue rollup#3989
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #4015 (81126fa) into master (cc4b56e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4015   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         192      192           
  Lines        6762     6762           
  Branches     1973     1973           
=======================================
  Hits         6574     6574           
  Misses        101      101           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4b56e...81126fa. Read the comment docs.

@lukastaegert lukastaegert merged commit 2368d9c into rollup:master Mar 25, 2021
lukastaegert pushed a commit that referenced this pull request Mar 27, 2021
Since SIGINT fails to actually kill them on some platforms under some circumstances,
leading to a whole lot of watch tests sitting around for 40 seconds until they
time out.

See derail in the discussion for issue #3989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants