Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sourcemap reference in docs #4012

Merged
merged 1 commit into from Mar 25, 2021
Merged

Conversation

tjenkinson
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

It's lowercase in the config.

Usually, a plugin will only omit the sourcemap if it (the plugin, not the bundle) was configured with sourcemap: false

Looks like the commmonjs plugin uses sourceMap 馃檲, so not sure if the line about plugins should be left as is, or maybe CommonJS should also accept sourcemap to be more inline with rollup itself?

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #4012 (ee52ddd) into master (170de9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4012   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         192      192           
  Lines        6762     6762           
  Branches     1973     1973           
=======================================
  Hits         6574     6574           
  Misses        101      101           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 170de9a...ee52ddd. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukastaegert lukastaegert merged commit cc4b56e into rollup:master Mar 25, 2021
lukastaegert pushed a commit that referenced this pull request Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants