Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run memory leak test on all systems #3887

Merged
merged 5 commits into from Nov 29, 2020
Merged

Run memory leak test on all systems #3887

merged 5 commits into from Nov 29, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This tries to make the memory leak test runnable on all Node and OS versions by switching to a different library and restructuring the test.

@rollup-bot
Copy link
Collaborator

rollup-bot commented Nov 29, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#memory-leak-test

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13648

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #3887 (0fedee0) into master (9949fe6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3887   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         187      187           
  Lines        6539     6539           
  Branches     1901     1901           
=======================================
  Hits         6348     6348           
  Misses        101      101           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9949fe6...0fedee0. Read the comment docs.

@lukastaegert lukastaegert merged commit fce057c into master Nov 29, 2020
@lukastaegert lukastaegert deleted the memory-leak-test branch November 29, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants