Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] add options hook to AsyncPluginHooks #3848

Merged
merged 1 commit into from Oct 31, 2020

Conversation

intrnl
Copy link
Contributor

@intrnl intrnl commented Oct 30, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

According to the docs, options hook is supposed to be async, and I checked the code as well.

This pull request fixes the corresponding types.

@intrnl
Copy link
Contributor Author

intrnl commented Oct 30, 2020

Hmm, there's something I noticed,

If the await inputOptions in this line resolves to null, then it wouldn't follow what the docs says,

Returning null does not replace anything

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #3848 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3848   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         184      184           
  Lines        6503     6503           
  Branches     1884     1884           
=======================================
  Hits         6312     6312           
  Misses        101      101           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e727c...0c082dc. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@lukastaegert lukastaegert merged commit c57aede into rollup:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants