New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stdin input with optional "-" as the file name. #3290
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3290 +/- ##
==========================================
+ Coverage 93.12% 93.13% +<.01%
==========================================
Files 170 171 +1
Lines 5966 6003 +37
Branches 1781 1792 +11
==========================================
+ Hits 5556 5591 +35
Misses 219 219
- Partials 191 193 +2
Continue to review full report at Codecov.
|
@lukastaegert Everything passing except for code coverage. Please add additional tests if you like. |
Thanks a lot. Just a note, it will take a while until I can work fully through this. |
Test coverage was improved, but was unable to get 100% patch coverage. For whatever reason I couldn't simulate a stdin read error on Node within CircleCI. The same test worked locally on all Node versions. That particular test was commented out in the PR. I don't plan to spend any more time on it. |
Just so there's no confusion, this PR works fine. That simulated stdin read error test is just a nice to have. It's not clear to me whether Node actually generates stdin read errors in any circumstance. |
* Only allow '-' to use stdin with the JS API * Use locally installed shx * Add test for stdin read error
Moving this to a local branch as there are still some changes I want to add |
Set default output format to "es" to save CLI typing for the most common case.
Closes #1440
Closes #3276
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#1440
#3276
Description
Implement stdin input with optional "-" as the file name.
Set default output format to "es" to save CLI typing for the most common case.