Prevent infinite deoptimizations

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
Resolves #3279

Description

This will resolve a situation that could result in the build hanging and eventually crashing due to an out-of-memory issue. Basically it was possible that while an AST node was deoptimizing dependent nodes, the loop it was iterating over was continually extended while it was being iterated.

[codecov]

Codecov Report

Merging #3280 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3280      +/-   ##
==========================================
+ Coverage   93.12%   93.13%   +<.01%     
==========================================
  Files         170      170              
  Lines        5960     5968       +8     
  Branches     1781     1781              
==========================================
+ Hits         5550     5558       +8     
  Misses        219      219              
  Partials      191      191

Impacted Files	Coverage Δ
src/ast/variables/LocalVariable.ts	89.01% <100%> (+0.24%)	⬆️
src/ast/nodes/LogicalExpression.ts	98.7% <100%> (+0.03%)	⬆️
src/ast/nodes/MemberExpression.ts	98.27% <100%> (+0.03%)	⬆️
src/ast/nodes/ConditionalExpression.ts	96.15% <100%> (+0.1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a562ec5...737f794. Read the comment docs.