Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make acornOptions optional in parse() in docs #3237

Merged
merged 2 commits into from Nov 18, 2019

Conversation

tjenkinson
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: N/A

Description

Make acornOptions optional in parse() in docs because in the types it is any and in the source it is optional

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting!

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #3237 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3237   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         170      170           
  Lines        5922     5922           
  Branches     1794     1794           
=======================================
  Hits         5405     5405           
  Misses        311      311           
  Partials      206      206

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4227977...d83e536. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants