Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing input options to output #3223

Merged
merged 1 commit into from Nov 11, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3222

Description

This fixes a regression where it is no longer possible to pass an object with an output key to bundle.generate.

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #3223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3223   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files         167      167           
  Lines        5911     5911           
  Branches     1793     1793           
=======================================
  Hits         5358     5358           
  Misses        336      336           
  Partials      217      217
Impacted Files Coverage Δ
src/rollup/index.ts 93.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fed410...c3b50f3. Read the comment docs.

@lukastaegert lukastaegert merged commit af8801b into master Nov 11, 2019
@lukastaegert lukastaegert deleted the gh-3222-allow-input-options-in-output branch November 11, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options for bundle#generate() are incorrectly passed
1 participant