Also recover from plugin errors during the initial build in watch mode #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3219 +/- ##
==========================================
+ Coverage 90.64% 90.64% +<.01%
==========================================
Files 167 167
Lines 5909 5911 +2
Branches 1792 1793 +1
==========================================
+ Hits 5356 5358 +2
Misses 336 336
Partials 217 217
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3215
Resolves #2534
Description
This is a follow-up of the #3081. The approach is still the same, but instead of attaching the necessary watch information to parse errors, it will be attached to any error during the build phase. This includes any errors thrown by plugins, but also many other obscure errors that can be encountered during that phase. Hopefully, watch mode is now more enjoyable for everyone.