New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "export * as name from …" #3193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove checks for duplicate exports as they are handled by Acorn
lukastaegert
force-pushed
the
export-all-as
branch
from
October 27, 2019 09:06
38c37f1
to
b59047c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3193 +/- ##
==========================================
+ Coverage 90.19% 90.63% +0.43%
==========================================
Files 167 167
Lines 5907 5905 -2
Branches 1797 1792 -5
==========================================
+ Hits 5328 5352 +24
+ Misses 350 336 -14
+ Partials 229 217 -12
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
export-all-as
branch
from
October 27, 2019 09:12
b59047c
to
4cb08a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #82
Description
As this syntax is now stable, we should definitely support it. This extends the same logic to this syntax as we have for namespace imports, meaning that
and
are equivalent up to the point that
becomes