Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treeshaken parameters around parentheses #2911

Merged
merged 1 commit into from Jun 9, 2019

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Jun 9, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2909
Close #2910

Description

this.arguments[lastIncludedIndex].end
),
this.end - 1
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I'll take yours 😜

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a simple enough (and fun) issue to debug! as usual https://astexplorer.net/ was my friend

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mine as well 😉

@lukastaegert lukastaegert merged commit a10a4fb into rollup:master Jun 9, 2019
@manucorporat manucorporat deleted the fix-treeshake-argument branch June 9, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treeshaking of arguments leads to SyntaxError
2 participants