Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect all module globals for CJS output from being redefined #2889

Merged
merged 1 commit into from Jun 1, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2886

Description

This PR makes sure that Rollup does not produce invalid CJS modules when module, require, __filename or __dirname are defined as top-level variables in modules.

@lukastaegert lukastaegert merged commit 53cde75 into master Jun 1, 2019
@lukastaegert lukastaegert deleted the gh-2886-avoid-module branch June 1, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module no longer avoided as a variable name
1 participant