Declare processConfigsErr before use

[humphd]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

I was following a suggestion from sveltejs/template#16 (comment) to add clearScreen: false to my rollup config.

Description

This fix deals with the case that a user specifies watch: { clearScreen: false } in their config, which currently causes the following error to be thrown:

ReferenceError: processConfigsErr is not defined
    at configs.map.options (/Users/humphd/Desktop/svelte-app/node_modules/rollup/b
in/rollup:1460:35)
    at Array.map (<anonymous>)
    at processConfigs (/Users/humphd/Desktop/svelte-app/node_modules/rollup/bin/ro
llup:1444:24)
    at watch (/Users/humphd/Desktop/svelte-app/node_modules/rollup/bin/rollup:1435
:28)
    at execute (/Users/humphd/Desktop/svelte-app/node_modules/rollup/bin/rollup:16
65:9)
    at loadConfigFile.then.configs (/Users/humphd/Desktop/svelte-app/node_modules/
rollup/bin/rollup:1656:30)
    at process._tickCallback (internal/process/next_tick.js:43:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:763:11)
    at startup (internal/bootstrap/node.js:303:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:872:3)

The problem here is that processConfigsErr is being set via processConfigs() before it is declared. Moving this declaration up before the call to processConfigs() fixes it.

[lukastaegert]

Thanks a lot for spotting this! Just for sport, I will see if there is an easy way to add a test before merging this as this is somewhat embarrassing ...

[lukastaegert]

I managed to add a test that at least fails with the previous version and which might serve as a template for more tests of the watch CLI in the future. From my side, this is good to go once CI is green.

[humphd]

@lukastaegert thanks writing a test for this. I wasn't sure how to add one for this, and felt badly not including one, but wanted to get the fix in regardless.