Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that rollup-plugin-commonjs works with preserveModules #2792

Merged
merged 2 commits into from Apr 5, 2019
Merged

Test that rollup-plugin-commonjs works with preserveModules #2792

merged 2 commits into from Apr 5, 2019

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 4, 2019 •
edited

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Originally this was meant to handle rollup/rollup-plugin-commonjs#371 but now it just adds another test

Description

@lukastaegert lukastaegert mentioned this pull request Apr 4, 2019
Merged
@lukastaegert lukastaegert changed the title Extend filename sanitation and test that rollup-plugin-commonjs works with preserveModules Test that rollup-plugin-commonjs works with preserveModules Apr 4, 2019
@lukastaegert lukastaegert merged commit 7837fc5 into master Apr 5, 2019
@lukastaegert lukastaegert deleted the extend-filename-sanitation branch April 5, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lukastaegert