Support Node-style format aliases #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
requested changes
Apr 1, 2019
|
I've also included the typing change - wasn't sure if that was wanted or not, but certainly can make sense. |
lukastaegert
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Node.js --experimental-modules has been updated, it has moved to longer names for formats as a standard in use in flags, package.json and loaders. So instead of
"cjs"it is"commonjs"and instead of"esm"it is"module".I know it's a pain, but I think it would be beneficial if we can support these aliases now, and possibly even consider them as the defaults in the long terms.
Apologies for whatever role I've played in churn here too :)