Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in export-globals test #2693

Merged
merged 2 commits into from Feb 15, 2019

Conversation

MattiasBuelens
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

#2691 introduced a small typo in the exports-globals form test. This fixes the typo, so the test does the right thing once again.

@MattiasBuelens MattiasBuelens mentioned this pull request Feb 14, 2019
9 tasks
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks a lot!

@MattiasBuelens
Copy link
Contributor Author

Tanks a lot!

Not sure if you're now intentionally writing more typos... 😝

Either way: no problem, happy to help. 😄

@lukastaegert lukastaegert merged commit c702f3a into rollup:master Feb 15, 2019
@MattiasBuelens MattiasBuelens deleted the export-globals-fix-typo branch February 15, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants